Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix omitting `--` from `process.execArgv` #24654

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Nov 26, 2018

This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
cli: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Nov 26, 2018

@addaleax sadly an error occured when I tried to trigger a build :(

@addaleax addaleax added the cli label Nov 26, 2018

@lpinca
lpinca approved these changes Nov 26, 2018
@danbev

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@Trott Trott added the author ready label Nov 29, 2018

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Landed in 83d6cb9

@Trott Trott closed this Nov 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 29, 2018
process: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: nodejs#24647

PR-URL: nodejs#24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos added a commit that referenced this pull request Nov 29, 2018
process: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
process: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: nodejs#24647

PR-URL: nodejs#24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
process: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
process: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
process: fix omitting `--` from `process.execArgv`
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.