Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: check for git tag before promoting release #24670

Conversation

@rvagg
Copy link
Member

commented Nov 27, 2018

Currently you can promote a release and then have signing fail because it finds you have no tag for that release or the tag isn't yours. Instead, do the check up-front and fail early to avoid mistakes.

@nodejs/releasers @nodejs/build

@rvagg rvagg added build tools labels Nov 27, 2018

@nodejs-github-bot

This comment has been minimized.

Copy link

commented Nov 27, 2018

@rvagg sadly an error occured when I tried to trigger a build :(

@rvagg rvagg force-pushed the rvagg:rvagg/release_script_check_tag_before_promotion branch from d861f54 to e59f387 Nov 27, 2018

@danbev
danbev approved these changes Nov 28, 2018
@rvagg

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

Used this plus #24669 for all 4 releases today, worked well

@Trott

This comment has been minimized.

@Trott Trott added the author ready label Dec 1, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

Landed in 84c2157

@Trott Trott closed this Dec 1, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2018
tools: check for git tag before promoting release
PR-URL: nodejs#24670
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
tools: check for git tag before promoting release
PR-URL: #24670
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
tools: check for git tag before promoting release
PR-URL: nodejs#24670
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
tools: check for git tag before promoting release
PR-URL: #24670
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
tools: check for git tag before promoting release
PR-URL: #24670
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.