New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe current HTTP header size limit #24700

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@sam-github
Copy link
Member

sam-github commented Nov 28, 2018

Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Nov 28, 2018

This does not replace #24693, it fixes the existing reference to 80KB in errors.md, but doesn't touch the HTTP docs themselves. It was intended that this be part of 1860352 but it got missed, sorry.

@mcollina
Copy link
Member

mcollina left a comment

LGTM

doc: describe current HTTP header size limit
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

@sam-github sam-github force-pushed the sam-github:doc-8kb-http-header-limit branch from bfb4d4a to 19cdee8 Nov 28, 2018

Show resolved Hide resolved doc/api/errors.md Outdated
fixup
Co-Authored-By: sam-github <vieuxtech@gmail.com>
@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Nov 28, 2018

sorry, misunderstood format of description field

@vsemozhetbyt

This comment has been minimized.

Copy link
Member

vsemozhetbyt commented Nov 28, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 28, 2018

Landed in 063e8fb

@Trott Trott closed this Nov 28, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018

doc: describe current HTTP header size limit
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

@sam-github sam-github deleted the sam-github:doc-8kb-http-header-limit branch Nov 28, 2018

targos added a commit that referenced this pull request Nov 29, 2018

doc: describe current HTTP header size limit
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

MylesBorins added a commit that referenced this pull request Dec 25, 2018

doc: describe current HTTP header size limit
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

doc: describe current HTTP header size limit
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v10.15.0 proposal #25176

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

doc: describe current HTTP header size limit
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment