Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minor refactoring of onticketkeycallback #24718

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Nov 29, 2018

The motivation for this commit is to make the the onticketkeycallback
function more readable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: minor refactoring of onticketkeycallback
The motivation for this commit is to make the the onticketkeycallback
function more readable.
@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@lpinca
lpinca approved these changes Nov 29, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

Landed in 82ceb5e

@Trott Trott closed this Dec 1, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2018
test: minor refactoring of onticketkeycallback
The motivation for this commit is to make the the onticketkeycallback
function more readable.

PR-URL: nodejs#24718
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
test: minor refactoring of onticketkeycallback
The motivation for this commit is to make the the onticketkeycallback
function more readable.

PR-URL: #24718
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete

@danbev danbev deleted the danbev:https-resume-after-renew branch Dec 7, 2018

refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: minor refactoring of onticketkeycallback
The motivation for this commit is to make the the onticketkeycallback
function more readable.

PR-URL: nodejs#24718
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: minor refactoring of onticketkeycallback
The motivation for this commit is to make the the onticketkeycallback
function more readable.

PR-URL: #24718
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
test: minor refactoring of onticketkeycallback
The motivation for this commit is to make the the onticketkeycallback
function more readable.

PR-URL: #24718
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.