Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD #24729
Add an error code property to invalid
Node errors are supposed to have a .code property, so use the new C++ errors framework.
@joyeecheung Its not clear to me whether this has to be semver-major. I changed the error type from
If any kind of change like this to the errors is semver-major by definition, then I won't bother splitting it up.
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19070/
Is https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64-gcc6/23597/testReport/junit/(root)/test/parallel_test_cli_syntax/ flaky @Trott ? I've seen it fail a couple times lately in TLS PRs that don't seem related, and it usually passes later on retry.
Very much so. Issue tracking it is #24403. If it's particularly irksome, we can mark it flaky in the status file. I'd personally prefer to keep noticing it and gathering information because it's failing in multiple ways, which is interesting. But I have a high tolerance for pain when it comes to re-running CI jobs, so my opinion may not deserve much weight there.
referenced this pull request
Jan 7, 2019
OK, not backporting this to 11.x is hurting the backport of TLS1.3 to 11.x.
TLS1.3 tests have many assertions on TLS error's
I propose backporting this to 11.x as semver-minor by changing the type of the error back to
The 11.x backport would then flow into 10.x as semver-minor as a pre-req for TLS1.3, so this affects LTS.