New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 6.5.0 #24734

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@aeschright
Copy link
Contributor

aeschright commented Nov 29, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 10
  • Node 8
Notable Changes

This is a pre-release of npm@6.5.0 including a number of bugfixes and documentation updates.

Another reminder that we've moved our issue tracking! You can read more about our move away from GitHub for issue tracking on our blog.

Changelogs
@zkat

This comment has been minimized.

Copy link
Contributor

zkat commented Nov 30, 2018

Oh right, node@11 is out now too. Should we add it to the list?

@targos

This comment has been minimized.

Copy link
Member

targos commented Nov 30, 2018

@zkat Do you mean the "Where this should land" list?
SGTM. It's not strictly necessary because we try to backport everything to Node 11 unless the PR is explicitly labeled dont-land-on-v11.x

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 2, 2018

This needs some reviews, although I imagine they'll be largely of the rubber-stamp variety... @nodejs/npm

@Trott

This comment has been minimized.

@addaleax
Copy link
Member

addaleax left a comment

Rubber-stamp LGTM

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 4, 2018

Only failure is a known flake … Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19187/

@targos targos added the blocked label Dec 4, 2018

@targos

This comment has been minimized.

Copy link
Member

targos commented Dec 4, 2018

Blocking until npm 6.5.0 has been latest for two weeks.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 4, 2018

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 11, 2018

6.5.0 has been promoted to latest... as such we can land this on December 25th... A holiday present!

@bricss bricss referenced this pull request Dec 18, 2018

Merged

V11.5.0 proposal #25102

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 25, 2018

@MylesBorins MylesBorins removed the blocked label Dec 25, 2018

@MylesBorins MylesBorins force-pushed the npm:npm-6.5.0 branch from fbc3d70 to 6edfb2d Dec 25, 2018

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 25, 2018

rebased against master, one more CI https://ci.nodejs.org/job/node-test-pull-request/19798/

@MylesBorins
Copy link
Member

MylesBorins left a comment

LGTM

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 25, 2018

landed in 13ae538

MylesBorins added a commit that referenced this pull request Dec 25, 2018

deps: upgrade npm to 6.5.0
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

pull bot pushed a commit to SimenB/node that referenced this pull request Dec 25, 2018

deps: upgrade npm to 6.5.0
PR-URL: nodejs#24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

2018-12-26, Version 11.6.0 (Current)
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

deps: upgrade npm to 6.5.0
PR-URL: #24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 26, 2018

2018-12-26, Version 11.6.0 (Current)
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

2018-12-26, Version 11.6.0 (Current)
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

2018-12-26, Version 11.6.0 (Current)
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    #24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    #24234
  - add key object API (Tobias Nießen) [#24234](#24234)
  - update root certificates (Sam Roberts)
    #25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    #25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    #24734
* http:
  - add maxHeaderSize property (cjihrig)
    #24860

PR-URL: #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

deps: upgrade npm to 6.5.0
PR-URL: nodejs#24734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

2018-12-26, Version 11.6.0 (Current)
Notable Changes:

* cli:
  - add --max-http-header-size flag (cjihrig)
    nodejs#24811
* crypto:
  - always accept certificates as public keys (Tobias Nießen)
    nodejs#24234
  - add key object API (Tobias Nießen) [nodejs#24234](nodejs#24234)
  - update root certificates (Sam Roberts)
    nodejs#25113
* deps:
  - upgrade to libuv 1.24.1 (cjihrig)
    nodejs#25078
  - upgrade npm to 6.5.0 (Audrey Eschright)
    nodejs#24734
* http:
  - add maxHeaderSize property (cjihrig)
    nodejs#24860

PR-URL: nodejs#25175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment