Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a missing (flag param) scenario in test-fs-write-file-sync #24766

Closed
wants to merge 1 commit into from

Conversation

@gireeshpunathil
Copy link
Member

commented Dec 1, 2018

(came across this while working on some thing). fs.writeFileSync takes flag param to define the file opening semantics. Add a scenario that covers flags as well.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@richardlau
Copy link
Member

left a comment

Commit title has a typo (scenraio->scenario).

test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

@gireeshpunathil gireeshpunathil force-pushed the gireeshpunathil:fsflag branch from 8b5d580 to b4ac19e Dec 1, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2018

@richardlau - fixed, thanks.

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2018

@Trott Trott added the author ready label Dec 1, 2018

@lpinca
lpinca approved these changes Dec 1, 2018
@cjihrig
cjihrig approved these changes Dec 1, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 4, 2018
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

PR-URL: nodejs#24766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

Landed in 02cd706

@Trott Trott closed this Dec 4, 2018

BridgeAR added a commit that referenced this pull request Dec 5, 2018
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

PR-URL: #24766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

PR-URL: #24766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

PR-URL: nodejs#24766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

PR-URL: #24766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

PR-URL: #24766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: add flag scenario in test-fs-write-file-sync
fs.writeFileSync takes flag param to define the file opening
semantics. Add a scenario that covers flags as well.

PR-URL: #24766
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.