Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove duplicated noop function #24770

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Dec 1, 2018

We have a noop function outside the if statement in the line 609 :)

function noop() {}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@cjihrig
cjihrig approved these changes Dec 1, 2018
@addaleax

This comment has been minimized.

@lpinca
lpinca approved these changes Dec 1, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

Needs a rebase.

@Trott Trott removed the author ready label Dec 4, 2018

@ZYSzys ZYSzys force-pushed the zys-contribs:bootstrap branch from e3338e8 to 8f99e33 Dec 4, 2018

@ZYSzys

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2018

@Trott Done, needs CI again ?

@danbev

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

@addaleax

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 4, 2018
lib: remove duplicated noop function
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

Landed in a89b873`

@Trott Trott closed this Dec 4, 2018

@ZYSzys ZYSzys deleted the zys-contribs:bootstrap branch Dec 4, 2018

BridgeAR added a commit that referenced this pull request Dec 5, 2018
lib: remove duplicated noop function
PR-URL: #24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
lib: remove duplicated noop function
PR-URL: #24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
lib: remove duplicated noop function
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
lib: remove duplicated noop function
PR-URL: #24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>

Backport-PR-URL: #25446
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
lib: remove duplicated noop function
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
lib: remove duplicated noop function
PR-URL: nodejs#24770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>

Backport-PR-URL: nodejs#25446
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.