Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: prepare tools/test.py for Python 3 #24799

Closed
wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Contributor

commented Dec 3, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Trott approved these changes Dec 6, 2018

@Trott Trott added the python label Dec 6, 2018

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

@danbev
danbev approved these changes Dec 7, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@nodejs/python This could use another reviewer.

@danbev

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

Landed in 29204f4.

@danbev danbev closed this Dec 7, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@Trott Sorry, I just noticed your comment after merging 😞

danbev added a commit that referenced this pull request Dec 7, 2018
tools: prepare tools/test.py for Python 3
PR-URL: #24799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@Trott Sorry, I just noticed your comment after merging 😞

No, you were right to merge it. Your approval came in seconds before my comment, making it obsolete just as I was making it. 😆

@cclauss cclauss deleted the cclauss:Py3-for-tools_test.py branch Dec 7, 2018

MylesBorins added a commit that referenced this pull request Dec 7, 2018
tools: prepare tools/test.py for Python 3
PR-URL: #24799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
tools: prepare tools/test.py for Python 3
PR-URL: nodejs#24799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
tools: prepare tools/test.py for Python 3
PR-URL: #24799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
tools: prepare tools/test.py for Python 3
PR-URL: #24799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
tools: prepare tools/test.py for Python 3
PR-URL: #24799
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.