Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove finalized_ member from Hash class #24822

Closed

Conversation

@danbev
Copy link
Member

commented Dec 4, 2018

This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: remove finalized_ member from Hash class
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.
@danbev

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2018

@cjihrig
cjihrig approved these changes Dec 4, 2018
@lpinca
lpinca approved these changes Dec 4, 2018
@danbev

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2018

Landed in cbf0e5a.

@danbev danbev closed this Dec 7, 2018

@danbev danbev deleted the danbev:crypto_hash_remove_finalized_var branch Dec 7, 2018

danbev added a commit that referenced this pull request Dec 7, 2018
src: remove finalized_ member from Hash class
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 7, 2018
src: remove finalized_ member from Hash class
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: remove finalized_ member from Hash class
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: nodejs#24822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
src: remove finalized_ member from Hash class
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
src: remove finalized_ member from Hash class
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
src: remove finalized_ member from Hash class
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.