Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding history regression test case #24843

Closed

Conversation

@antsmartian
Copy link
Contributor

commented Dec 5, 2018

Recently added mulitline caused a issue in history navigation ref: #24385

Fundamentally, we don't had a test case for navigation till now, the one I see here: https://github.com/nodejs/node/blob/master/test/parallel/test-repl-persistent-history.js#L97, just tests one level navigation.

cc @nodejs/repl @BridgeAR

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Dec 5, 2018

@antsmartian sadly an error occured when I tried to trigger a build :(

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2018

@antsmartian antsmartian force-pushed the antsmartian:repl-history-test-case branch from 912aa88 to 078dfa8 Dec 7, 2018

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@BridgeAR ping...

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

@nodejs/repl @BridgeAR Gentle remainder 🔉

},
{
env: {},
test: [UP, UP, UP, DOWN, DOWN, DOWN],

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Dec 12, 2018

Member

I suggest to add one more UP and one more DOWN so we reach the end of the list in both cases.

This comment has been minimized.

Copy link
@antsmartian

antsmartian Dec 13, 2018

Author Contributor

Yeah, taken care of this. Guess should be good now.. cc @BridgeAR

@antsmartian antsmartian force-pushed the antsmartian:repl-history-test-case branch from 078dfa8 to 9d7ce13 Dec 13, 2018

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2018

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

@BridgeAR Can you please just have a look now, have addressed your comments and I wanted to take your review once before I land this to master.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

Still LG but please run a regular CI

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

Yeah sure, thanks much @BridgeAR.

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

Landed in 0bf7d41

@Trott Trott closed this Dec 15, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 15, 2018
test: adding history regression test case
PR-URL: nodejs#24843
Refs: nodejs#24385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2018

Thanks @Trott

@antsmartian antsmartian deleted the antsmartian:repl-history-test-case branch Dec 15, 2018

BethGriggs added a commit that referenced this pull request Dec 18, 2018
test: adding history regression test case
PR-URL: #24843
Refs: #24385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
sagitsofan added a commit to sagitsofan/node that referenced this pull request Dec 24, 2018
test: adding history regression test case
PR-URL: nodejs#24843
Refs: nodejs#24385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: adding history regression test case
PR-URL: nodejs#24843
Refs: nodejs#24385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: adding history regression test case
PR-URL: #24843
Refs: #24385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: adding history regression test case
PR-URL: #24843
Refs: #24385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: adding history regression test case
PR-URL: #24843
Refs: #24385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.