Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update http doc for new Agent()/support options in socket.connect() #24846

Closed
wants to merge 2 commits into from

Conversation

@BeniCheni
Copy link
Contributor

commented Dec 5, 2018

Refs #24098, list the supported options in socket.connect() for new Agent() signature in http doc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
doc/api/http.md Outdated Show resolved Hide resolved
BeniCheni added 2 commits Dec 5, 2018
doc: update http doc for new Agent()/support options in socket.connect()
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098
@BeniCheni

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2018

Thanks, @vsemozhetbyt. Updated to use a separate note for socket.connect's options, and correct the link to a bottom reference. Ready for review when convenient.

@vsemozhetbyt
Copy link
Contributor

left a comment

Doc format LGTM.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2018

cc @nodejs/http

@lpinca
lpinca approved these changes Dec 7, 2018
@trivikr
trivikr approved these changes Dec 8, 2018
@vsemozhetbyt

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

Landed in 22564b9

@Trott Trott closed this Dec 8, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2018
doc: update http doc for new Agent()/support options in socket.connect()
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: nodejs#24098

PR-URL: nodejs#24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@BeniCheni BeniCheni deleted the BeniCheni:doc-agent-newable-options branch Dec 8, 2018

BethGriggs added a commit that referenced this pull request Dec 17, 2018
doc: update http doc for new Agent()/support options in socket.connect()
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: update http doc for new Agent()/support options in socket.connect()
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: nodejs#24098

PR-URL: nodejs#24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
doc: update http doc for new Agent()/support options in socket.connect()
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
doc: update http doc for new Agent()/support options in socket.connect()
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
doc: update http doc for new Agent()/support options in socket.connect()
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.