Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test-net-socket-timeout #24859

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Dec 5, 2018

  • Check for custom Node.js code rather than constructor in
    assert.throws().
  • Use arrow functions consistently.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: improve test-net-socket-timeout
* Check for custom Node.js code rather than constructor in
  assert.throws().
* Use arrow functions consistently.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 5, 2018

@cjihrig
cjihrig approved these changes Dec 5, 2018
@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

@Trott Trott added the author ready label Dec 6, 2018

@trivikr
trivikr approved these changes Dec 8, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2018
test: improve test-net-socket-timeout
* Check for custom Node.js code rather than constructor in
  assert.throws().
* Use arrow functions consistently.

PR-URL: nodejs#24859
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2018

Landed in 6780683

@Trott Trott closed this Dec 8, 2018

targos added a commit that referenced this pull request Dec 8, 2018
test: improve test-net-socket-timeout
* Check for custom Node.js code rather than constructor in
  assert.throws().
* Use arrow functions consistently.

PR-URL: #24859
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: improve test-net-socket-timeout
* Check for custom Node.js code rather than constructor in
  assert.throws().
* Use arrow functions consistently.

PR-URL: nodejs#24859
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: improve test-net-socket-timeout
* Check for custom Node.js code rather than constructor in
  assert.throws().
* Use arrow functions consistently.

PR-URL: #24859
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: improve test-net-socket-timeout
* Check for custom Node.js code rather than constructor in
  assert.throws().
* Use arrow functions consistently.

PR-URL: #24859
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: improve test-net-socket-timeout
* Check for custom Node.js code rather than constructor in
  assert.throws().
* Use arrow functions consistently.

PR-URL: #24859
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.