Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: use validateString in modules/esm #24868

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Dec 6, 2018

Almost same as #24863 :)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Dec 6, 2018
@trivikr
trivikr approved these changes Dec 8, 2018
@trivikr

This comment has been minimized.

@trivikr trivikr added the author ready label Dec 8, 2018

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 9, 2018

@ZYSzys

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

@Trott It seems to be failed again.😅 Wondering what can I do for it ?

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 9, 2018

Yeah, turns out failures are likely relevant. Bug in this PR perhaps?

@Trott Trott removed the author ready label Dec 9, 2018

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@Trott the failure looks unrelated to me. The failures from the CI runs also differ, so it's another indicator that it's unrelated. The code change seems to be fine and the functionality should also be identical to the one before.

Resumed CI https://ci.nodejs.org/job/node-test-commit/24157/ ✔️

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@Trott the failure looks unrelated to me. The failures from the CI runs also differ, so it's another indicator that it's unrelated.

Failure on ARM w/gcc 6 was identical in both runs and appears to be related to module loading, so seems likely related to this PR. But yes, I could be wrong.

Refs: https://ci.nodejs.org/job/node-test-commit-arm/20651/
Refs: https://ci.nodejs.org/job/node-test-commit-arm/20647/

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Resume Build was successful, so I guess we're good. Although just to be sure...

ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20687/ 😞
ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20688/ ✔️
ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20689/ 😞

(I expect those will pass, but given the current state of CI, I'm also keen to take extra care that we don't introduce another unreliable test. test-cli-syntax has been brutal....)

Argh, looks like this test is already flaky...

@Trott Trott added author ready and removed author ready labels Dec 10, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Oh, yeah, already flaky. Here it is failing for #24924: https://ci.nodejs.org/job/node-test-commit-arm/20670/

@Trott Trott added the author ready label Dec 10, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2018
module: use validateString in modules/esm
PR-URL: nodejs#24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Landed in d695a01.

(Sorry for causing an unnecessary delay on landing this.)

@Trott Trott closed this Dec 10, 2018

@ZYSzys ZYSzys deleted the zys-contribs:validator-string-esm branch Dec 11, 2018

BethGriggs added a commit that referenced this pull request Dec 17, 2018
module: use validateString in modules/esm
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
module: use validateString in modules/esm
PR-URL: nodejs#24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
module: use validateString in modules/esm
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
module: use validateString in modules/esm
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
module: use validateString in modules/esm
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.