New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove internalBinding('config').warningFile #24959

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@joyeecheung
Copy link
Member

joyeecheung commented Dec 11, 2018

Instead use require('internal/options') lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: remove internalBinding('config').warningFile
Instead use `require('internal/options')` lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.
@addaleax

This comment has been minimized.

@addaleax addaleax referenced this pull request Dec 11, 2018

Closed

process: improve `--redirect-warnings` handling #24965

4 of 4 tasks complete
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 12, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2018

Landed in e989269

@Trott Trott closed this Dec 14, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018

src: remove internalBinding('config').warningFile
Instead use `require('internal/options')` lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.

PR-URL: nodejs#24959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

sam-github added a commit to sam-github/node that referenced this pull request Dec 14, 2018

src: remove internalBinding('config').warningFile
Instead use `require('internal/options')` lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.

PR-URL: nodejs#24959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

src: remove internalBinding('config').warningFile
Instead use `require('internal/options')` lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.

PR-URL: #24959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: remove internalBinding('config').warningFile
Instead use `require('internal/options')` lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.

PR-URL: nodejs#24959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment