New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor argument validation using validateString #24960

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@ZYSzys
Copy link
Member

ZYSzys commented Dec 11, 2018

Refs: #22101

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Dec 11, 2018

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 12, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2018

Landed in a35bd62

@Trott Trott closed this Dec 14, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018

lib: refactor argument validation using validateString
PR-URL: nodejs#24960
Refs: nodejs#22101
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

sam-github added a commit to sam-github/node that referenced this pull request Dec 14, 2018

lib: refactor argument validation using validateString
PR-URL: nodejs#24960
Refs: nodejs#22101
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

lib: refactor argument validation using validateString
PR-URL: #24960
Refs: #22101
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

lib: refactor argument validation using validateString
PR-URL: nodejs#24960
Refs: nodejs#22101
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment