New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: inspect getters #25004

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@BridgeAR
Copy link
Member

BridgeAR commented Dec 13, 2018

While asserting two objects the descriptor is not taken into account.
Therefore getters will be triggered as such. This makes sure they
are also highlighted in the error message instead of potentially
looking identical while the return value of the getter is actually
different.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
assert: inspect getters
While asserting two objects the descriptor is not taken into account.
Therefore getters will be triggered as such. This makes sure they
are also highlighted in the error message instead of potentially
looking identical while the return value of the getter is actually
different.
@BridgeAR

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 14, 2018

@BridgeAR BridgeAR requested review from addaleax , targos and devsnek Dec 14, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2018

This could conceivably make tests fail where they currently succeed. In many cases, that's probably more of a bugfix than a breaking change. But not all, I don't think.

This is the internal conversation I'm having with myself that has prevented me from approving this up until now. It looks good to me, but I wonder.

Is a CITGM run a good idea here?

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 15, 2018

@Trott I am sorry but I am not sure I can follow. Do you mean a test that checks the assertion message? We changed that multiple times so far and I am not aware of any issues about that (anymore).

Just so we are aligned: the actual comparison is not changed here at all. That comparison already triggers the getters and it's just the error output which is changed.

@Trott

Trott approved these changes Dec 15, 2018

@targos

targos approved these changes Dec 15, 2018

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 17, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 17, 2018

Resume Build had 100% failure on fanned jobs, which I'm guessing is because something cached got dropped from Jenkins. CI: https://ci.nodejs.org/job/node-test-pull-request/19634/ (scheduled)

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 18, 2018

Landed in 3b2698e

@BridgeAR BridgeAR closed this Dec 18, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 18, 2018

assert: inspect getters
While asserting two objects the descriptor is not taken into account.
Therefore getters will be triggered as such. This makes sure they
are also highlighted in the error message instead of potentially
looking identical while the return value of the getter is actually
different.

PR-URL: nodejs#25004
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

assert: inspect getters
While asserting two objects the descriptor is not taken into account.
Therefore getters will be triggered as such. This makes sure they
are also highlighted in the error message instead of potentially
looking identical while the return value of the getter is actually
different.

PR-URL: #25004
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

assert: inspect getters
While asserting two objects the descriptor is not taken into account.
Therefore getters will be triggered as such. This makes sure they
are also highlighted in the error message instead of potentially
looking identical while the return value of the getter is actually
different.

PR-URL: nodejs#25004
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment