Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove dead code #25009

Closed
wants to merge 2 commits into from

Conversation

@BridgeAR
Copy link
Member

commented Dec 13, 2018

This is not used by the test anymore.

I am uncertain why this is not found by eslint but I did not check.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
test: remove dead code
This is not used by the test anymore.
test: run eslint on test file and fix errors
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.
@@ -1,9 +1,7 @@
node_modules
lib/internal/v8.js
lib/internal/v8_prof_polyfill.js

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Dec 13, 2018

Author Member

I am not sure what this file does. Do we have to ignore the file here?

This comment has been minimized.

Copy link
@Trott

Trott Dec 15, 2018

Member

My vague recollection: I think the file was originally copied from either V8 source or a V8 change proposal that may have been rejected by V8. Since we were copying the file, we didn't apply our lint style to it since we would just copy changes from upstream at a later date, presumably. This is similar, I think, to how we handle punycode.js. It looks like we may now basically own v8_prof_polyfill.js, though. I'm not sure. @matthewloring may know,.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

@Trott
Trott approved these changes Dec 13, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 15, 2018
test: remove dead code
This is not used by the test anymore.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Dec 15, 2018
test: run eslint on test file and fix errors
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

Landed in e7c3a1b...1395256

@Trott Trott closed this Dec 15, 2018

BethGriggs added a commit that referenced this pull request Dec 18, 2018
test: remove dead code
This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 18, 2018
test: run eslint on test file and fix errors
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: remove dead code
This is not used by the test anymore.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: run eslint on test file and fix errors
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: nodejs#25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: remove dead code
This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: run eslint on test file and fix errors
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: remove dead code
This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: run eslint on test file and fix errors
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: remove dead code
This is not used by the test anymore.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: run eslint on test file and fix errors
This removes two entries from the eslint ignore file. One file does
not exist anymore and the other one could easily be fixed.

PR-URL: #25009
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.