New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add a space to clarify skipping crypto msg #25011

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@danbev
Copy link
Member

danbev commented Dec 13, 2018

This commit adds a space to the message that is displayed for tests that
are skipped when node was built --without-ssl. For example, this is what
is currently displayed:

"release test-https-agent-additional-optionsSkipping as node was compiled
without crypto support"

After this change this will be:

"release test-https-agent-additional-options: Skipping as node was compiled
without crypto support"
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
build: add a space to clarify skipping crypto msg
This commit adds a space to the message that is displayed for tests that
are skipped when node was built --without-ssl. For example, this is what
is currently displayed:
"release test-https-agent-additional-optionsSkipping as node was
compiled without crypto support"

After this change this will be:
"release test-https-agent-additional-options Skipping as node was
compiled without crypto support"

@danbev danbev force-pushed the danbev:build-without-ssl-skipping-msg branch from 01b4894 to bead436 Dec 13, 2018

@BridgeAR
Copy link
Member

BridgeAR left a comment

LGTM but I would even go a bit further and add a colon or something like that to make it even more clear.

@lpinca

lpinca approved these changes Dec 13, 2018

@danbev

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2018

ARM was the only red result in the last CI run with a pair of addon failures seen elsewhere on ARM CI runs, and the re-run of ARM is green, so CI is effectively green.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 17, 2018

Landed in 1631052.

@danbev danbev closed this Dec 17, 2018

@danbev danbev deleted the danbev:build-without-ssl-skipping-msg branch Dec 17, 2018

@thefourtheye

This comment has been minimized.

Copy link
Contributor

thefourtheye commented Dec 17, 2018

@danbev The landed commit is missing the metadata.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 17, 2018

@thefourtheye :( Thanks, I'm going to fix and force push.

pull bot pushed a commit to zys-contribs/node that referenced this pull request Dec 17, 2018

build: add a space to clarify skipping crypto msg
This commit adds a space to the message that is displayed for tests that
are skipped when node was built --without-ssl. For example, this is what
is currently displayed:
"release test-https-agent-additional-optionsSkipping as node was
compiled without crypto support"

After this change this will be:
"release test-https-agent-additional-options: Skipping as node was
compiled without crypto support"

PR-URL: nodejs#25011
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

build: add a space to clarify skipping crypto msg
This commit adds a space to the message that is displayed for tests that
are skipped when node was built --without-ssl. For example, this is what
is currently displayed:
"release test-https-agent-additional-optionsSkipping as node was
compiled without crypto support"

After this change this will be:
"release test-https-agent-additional-options: Skipping as node was
compiled without crypto support"

PR-URL: #25011
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

build: add a space to clarify skipping crypto msg
This commit adds a space to the message that is displayed for tests that
are skipped when node was built --without-ssl. For example, this is what
is currently displayed:
"release test-https-agent-additional-optionsSkipping as node was
compiled without crypto support"

After this change this will be:
"release test-https-agent-additional-options: Skipping as node was
compiled without crypto support"

PR-URL: nodejs#25011
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment