Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use global.gc() instead of gc() #25012

Merged
merged 1 commit into from Dec 15, 2018

Conversation

@cjihrig
Copy link
Contributor

commented Dec 13, 2018

This change is made for consistency, and to remove an eslint-disable comment.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@ChALkeR
Copy link
Member

left a comment

Seems to be the only place in tests/benchmarks.

LGTM.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

I believe the lite CI is enough here.

@lpinca
lpinca approved these changes Dec 13, 2018
@Trott
Trott approved these changes Dec 13, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

I believe the lite CI is enough here.

I'd prefer we not try to make those judgments. If executable code is changed, CI should be run.

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

Now that a few more tests are marked flaky, lets' try another CI: https://ci.nodejs.org/job/node-test-pull-request/19550/

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2018

test: use global.gc() instead of gc()
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:gc branch from 17d9fc8 to 715e3c6 Dec 15, 2018

@cjihrig cjihrig merged commit 715e3c6 into nodejs:master Dec 15, 2018

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:gc branch Dec 15, 2018

BethGriggs added a commit that referenced this pull request Dec 18, 2018
test: use global.gc() instead of gc()
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: use global.gc() instead of gc()
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: nodejs#25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: use global.gc() instead of gc()
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
test: use global.gc() instead of gc()
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: use global.gc() instead of gc()
This change is made for consistency, and to remove an
eslint-disable comment.

PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.