New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: merge test with unnecessary child process #25025

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@sam-github
Copy link
Member

sam-github commented Dec 13, 2018

Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.

@addaleax @Trott You agree?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
test: merge test with unnecessary child process
Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.

@sam-github sam-github requested review from Trott and addaleax Dec 13, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 13, 2018

Original test was added by @tniessen in 88351a2 so pinging them...

// This used to segfault. See: https://github.com/nodejs/node/issues/9819
common.expectsError(
() => crypto.createHmac('sha256', 'key').digest({
toString: () => { throw new Error("boom"); },

This comment has been minimized.

@Trott

Trott Dec 13, 2018

Member

Linter complains about double-quote on this line.

@Trott

Trott approved these changes Dec 13, 2018

@cjihrig
Copy link
Contributor

cjihrig left a comment

LGTM with the double quotes changed to single quotes.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 14, 2018

Looks like there are competing CI runs for this that both are running on the same commit.

CI: https://ci.nodejs.org/job/node-test-pull-request/19535/
CI: https://ci.nodejs.org/job/node-test-pull-request/19545/

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 15, 2018

Between the two CIs, all variants have passed.

@Trott Trott added the author ready label Dec 15, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 17, 2018

Landed in b54d4a6

@Trott Trott closed this Dec 17, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 17, 2018

test: merge test with unnecessary child process
Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.

PR-URL: nodejs#25025
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

test: merge test with unnecessary child process
Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.

PR-URL: #25025
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

test: merge test with unnecessary child process
Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.

PR-URL: nodejs#25025
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment