Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-cli-node-options flaky on arm #25032

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Dec 14, 2018

Collaborators, 馃憤 here to fast-track.

Refs: #25028

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

ARM failure was a different pair of tests that I believe is infra-related. Affected host as been taken offline. Rebuild: https://ci.nodejs.org/job/node-test-commit-arm/20816/ 鉁旓笍

Rest of CI is good, so if that passes, this can land.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

Landed in adf5083

@Trott Trott closed this Dec 14, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
test: mark test-cli-node-options flaky on arm
Refs: nodejs#25028

PR-URL: nodejs#25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sam-github added a commit to sam-github/node that referenced this pull request Dec 14, 2018
test: mark test-cli-node-options flaky on arm
Refs: nodejs#25028

PR-URL: nodejs#25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs added a commit that referenced this pull request Dec 18, 2018
test: mark test-cli-node-options flaky on arm
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@BethGriggs BethGriggs referenced this pull request Dec 18, 2018
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: mark test-cli-node-options flaky on arm
Refs: nodejs#25028

PR-URL: nodejs#25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: mark test-cli-node-options flaky on arm
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: mark test-cli-node-options flaky on arm
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: mark test-cli-node-options flaky on arm
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@codebytere codebytere referenced this pull request Jan 29, 2019
codebytere added a commit that referenced this pull request Jan 29, 2019
test: mark test-cli-node-options flaky on arm
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: mark test-cli-node-options flaky on arm
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: mark test-cli-node-options flaky on arm
Refs: #25028

PR-URL: #25032
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.