New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x] http: fix regression of binary upgrade response body #25036

Closed
wants to merge 1 commit into
base: v6.x
from

Conversation

Projects
None yet
4 participants
@mcollina
Copy link
Member

mcollina commented Dec 14, 2018

See: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@mcollina

This comment has been minimized.

Copy link
Member

mcollina commented Dec 14, 2018

@mcollina

This comment has been minimized.

Copy link
Member

mcollina commented Dec 14, 2018

@mcollina mcollina changed the title http: fix regression of binary upgrade response body [v6.x] http: fix regression of binary upgrade response body Dec 14, 2018

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Dec 14, 2018

I think both this and #25037 can be cherry-picked from #25039 once merged no?

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Dec 14, 2018

Ignore the above comment (#24958 (comment))

@MylesBorins
Copy link
Member

MylesBorins left a comment

LGTM

MylesBorins added a commit that referenced this pull request Dec 21, 2018

http: fix regression of binary upgrade response body
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 21, 2018

landed in 8af2553

MylesBorins added a commit that referenced this pull request Dec 21, 2018

http: fix regression of binary upgrade response body
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 21, 2018

Merged

v6.16.0 proposal #25178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment