New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] http: fix regression of binary upgrade response body #25037

Closed
wants to merge 1 commit into
base: v8.x
from

Conversation

Projects
None yet
4 participants
@mcollina
Member

mcollina commented Dec 14, 2018

See: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@mcollina

This comment has been minimized.

Member

mcollina commented Dec 14, 2018

@mcollina

This comment has been minimized.

@mcollina mcollina changed the title http: fix regression of binary upgrade response body [8.x] http: fix regression of binary upgrade response body Dec 14, 2018

@Trott

This comment has been minimized.

Member

Trott commented Dec 14, 2018

@Trott

This comment has been minimized.

Member

Trott commented Dec 14, 2018

sequential/test-http2-settings-flood failed on same Windows variant both CI runs. Wouldn't think it's relevant, but maybe? Or maybe it's flaky on v8.x?

@Trott

This comment has been minimized.

Member

Trott commented Dec 14, 2018

@mcollina

This comment has been minimized.

Member

mcollina commented Dec 14, 2018

It's definitely not relevant.

@MylesBorins
Member

MylesBorins left a comment

LGTM

MylesBorins added a commit that referenced this pull request Dec 21, 2018

http: fix regression of binary upgrade response body
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Dec 21, 2018

landed in a947b75

@mcollina mcollina deleted the mcollina:8-remove-spurious-http-fix branch Dec 21, 2018

MylesBorins added a commit that referenced this pull request Dec 21, 2018

http: fix regression of binary upgrade response body
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 21, 2018

Merged

v8.15.0 proposal #25177

MylesBorins added a commit that referenced this pull request Dec 22, 2018

http: fix regression of binary upgrade response body
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment