New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] http: fix regression of binary upgrade response body #25039

Closed
wants to merge 1 commit into
base: v10.x
from

Conversation

Projects
None yet
3 participants
@mcollina
Copy link
Member

mcollina commented Dec 14, 2018

Fixes: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@mcollina mcollina force-pushed the mcollina:10-remove-spurious-http-fix branch from f0e34d8 to 2f62ca9 Dec 14, 2018

@mcollina mcollina changed the base branch from v10.x-staging to v10.x Dec 14, 2018

@mcollina

This comment has been minimized.

Copy link
Member

mcollina commented Dec 14, 2018

@mcollina

This comment has been minimized.

Copy link
Member

mcollina commented Dec 14, 2018

@MylesBorins
Copy link
Member

MylesBorins left a comment

LGTM

MylesBorins added a commit that referenced this pull request Dec 21, 2018

http: fix regression of binary upgrade response body
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Dec 21, 2018

landed in c5140f5

MylesBorins added a commit that referenced this pull request Dec 21, 2018

http: fix regression of binary upgrade response body
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 21, 2018

Merged

v10.15.0 proposal #25176

MylesBorins added a commit that referenced this pull request Dec 22, 2018

http: fix regression of binary upgrade response body
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 22, 2018

http: fix regression of binary upgrade response body
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

http: fix regression of binary upgrade response body
PR-URL: #25039
Fixes: #24958
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment