New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: mark some global state as const #25052

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@addaleax
Copy link
Member

addaleax commented Dec 14, 2018

Mark some global variables as const or constexpr.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax changed the title src: make some global state as const src: mark some global state as const Dec 14, 2018

src: mark some global state as const
Mark some global variables as `const` or `constexpr`.

@addaleax addaleax force-pushed the addaleax:more-const branch from f3c257f to d450471 Dec 14, 2018

@addaleax

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 15, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 15, 2018

Windows CI failures related?

Show resolved Hide resolved src/node_file.cc Outdated
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 15, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 15, 2018

One red CI failure on AIX is not something I've seen before, or not seen much of anyway, but it looks like it's caused by the same thing as the other child-process failures in tests. Opened #25068 to track it but in the meantime:

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19567/

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 16, 2018

New failure is not seen before recently and appears to be caused by the same bug as other recent CI failures. Opened an issue for it: #25070

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19571/ ✔️

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 17, 2018

Landed in 18f2bf7

@Trott Trott closed this Dec 17, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 17, 2018

src: mark some global state as const
Mark some global variables as `const` or `constexpr`.

PR-URL: nodejs#25052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

src: mark some global state as const
Mark some global variables as `const` or `constexpr`.

PR-URL: #25052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: mark some global state as const
Mark some global variables as `const` or `constexpr`.

PR-URL: nodejs#25052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment