New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks: make GC tracking state per-Environment #25053

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@addaleax
Copy link
Member

addaleax commented Dec 14, 2018

Otherwise this is global state that may be subject to race
conditions e.g. when running perf_hooks inside of Worker threads.

Tracking the GC type is removed entirely since the variable was unused.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@cjihrig
Copy link
Contributor

cjihrig left a comment

LGTM. Could you maybe add a note to the commit log that performance_last_gc_type_ is removed due to not being used?

perf_hooks: make GC tracking state per-Environment
Otherwise this is global state that may be subject to race
conditions e.g. when running `perf_hooks` inside of Worker threads.

Tracking the GC type is removed entirely since the variable was unused.

@addaleax addaleax force-pushed the addaleax:perf-per-env branch from 89e0dd5 to f1511e4 Dec 14, 2018

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 14, 2018

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 17, 2018

Landed in 8dfd757

@addaleax addaleax closed this Dec 17, 2018

@addaleax addaleax deleted the addaleax:perf-per-env branch Dec 17, 2018

addaleax added a commit that referenced this pull request Dec 17, 2018

perf_hooks: make GC tracking state per-Environment
Otherwise this is global state that may be subject to race
conditions e.g. when running `perf_hooks` inside of Worker threads.

Tracking the GC type is removed entirely since the variable was unused.

PR-URL: #25053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

perf_hooks: make GC tracking state per-Environment
Otherwise this is global state that may be subject to race
conditions e.g. when running `perf_hooks` inside of Worker threads.

Tracking the GC type is removed entirely since the variable was unused.

PR-URL: #25053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

perf_hooks: make GC tracking state per-Environment
Otherwise this is global state that may be subject to race
conditions e.g. when running `perf_hooks` inside of Worker threads.

Tracking the GC type is removed entirely since the variable was unused.

PR-URL: nodejs#25053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment