New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: simplify Script constructor options validation #25054

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@cjihrig
Copy link
Contributor

cjihrig commented Dec 15, 2018

This commit combines two related if statements into an if-else statement.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
vm: simplify Script constructor options validation
This commit combines two related if statements into an
if-else statement.
@targos

targos approved these changes Dec 15, 2018

@lpinca

lpinca approved these changes Dec 15, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 16, 2018

@Trott Trott added the author ready label Dec 16, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 17, 2018

Landed in 52ee55a

@Trott Trott closed this Dec 17, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 17, 2018

vm: simplify Script constructor options validation
This commit combines two related if statements into an
if-else statement.

PR-URL: nodejs#25054
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@cjihrig cjihrig deleted the cjihrig:elseif branch Dec 17, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

vm: simplify Script constructor options validation
This commit combines two related if statements into an
if-else statement.

PR-URL: #25054
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

vm: simplify Script constructor options validation
This commit combines two related if statements into an
if-else statement.

PR-URL: nodejs#25054
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment