New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test methods of internal/util/types in vm #25056

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@ZYSzys
Copy link
Member

ZYSzys commented Dec 15, 2018

Test those methods of internal/util/types using vm.runInNewContext like previous types.isUint8Array

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@targos

targos approved these changes Dec 15, 2018

@lpinca

lpinca approved these changes Dec 15, 2018

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Dec 15, 2018

@Trott Trott added the author ready label Dec 15, 2018

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 18, 2018

Landed in 8828426.

@danbev danbev closed this Dec 18, 2018

danbev added a commit that referenced this pull request Dec 18, 2018

test: test internal/util/types in vm
PR-URL: #25056
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@ZYSzys ZYSzys deleted the zys-contribs:test-util-types branch Dec 18, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

test: test internal/util/types in vm
PR-URL: #25056
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

test: test internal/util/types in vm
PR-URL: nodejs#25056
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment