New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: mark options parsers as const #25065

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@addaleax
Copy link
Member

addaleax commented Dec 15, 2018

These do not change their contents after being constructed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: mark options parsers as const
These do not change their contents after being constructed.
@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 19, 2018

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 20, 2018

Re-run of failing node-test-commit-smartos ✔️

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 20, 2018

Landed in 6b7816e.

@danbev danbev closed this Dec 20, 2018

danbev added a commit that referenced this pull request Dec 20, 2018

src: mark options parsers as const
These do not change their contents after being constructed.

PR-URL: #25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

src: mark options parsers as const
These do not change their contents after being constructed.

PR-URL: #25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

src: mark options parsers as const
These do not change their contents after being constructed.

PR-URL: #25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: mark options parsers as const
These do not change their contents after being constructed.

PR-URL: nodejs#25065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment