New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: exit sequence sanity tests #25083

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
6 participants
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Dec 17, 2018

Execute many module loads in worker in a loop
while exiting from the main thread at arbitrary
execution points, and make sure that the workers
quiesce without crashing.

worker_threads are not necessarily the subject of
testing, those are used for easy simulation of
multi-thread scenarios.

Refs: #25007

The current code base is not yet ready to conceive this, so please don't land this before #25007 is fully resolved.

Checklist
@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

gireeshpunathil commented Jan 25, 2019

given that #25061 is landed now, making first attempt in CI to see where we do stand. It passes in Linux locally, but I am interested in other platforms that have variations in thread inetractions.

CI: https://ci.nodejs.org/job/node-test-pull-request/20319/

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

gireeshpunathil commented Jan 25, 2019

windows failure 08:28:59 not ok 497 parallel/test-trace-events-fs-sync is known through #25512

and arm failure 08:16:37 not ok 342 sequential/test-performance is known through #23291

@gireeshpunathil gireeshpunathil changed the title [do not land] test: exit sequence sanity tests test: exit sequence sanity tests Jan 25, 2019

@gireeshpunathil gireeshpunathil requested review from addaleax and Trott Jan 25, 2019

@gireeshpunathil

This comment has been minimized.

test: exit sequence sanity tests
Execute many module loads in worker in a loop
while exiting from the main thread at arbitrary
execution points, and make sure that the workers
quiesce without crashing.

`worker_threads` are not necessarily the subject of
testing, those are used for easy simulation of
multi-thread scenarios.

Refs: #25007
PR-URL: #25083
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gireeshpunathil gireeshpunathil force-pushed the gireeshpunathil:exitrace1 branch from ae6c952 to c3fd504 Jan 29, 2019

@gireeshpunathil gireeshpunathil merged commit c3fd504 into nodejs:master Jan 29, 2019

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

gireeshpunathil commented Jan 29, 2019

landed as c3fd504

@gireeshpunathil gireeshpunathil referenced this pull request Jan 29, 2019

Merged

test: exit sequence sanity tests [2] #25085

3 of 3 tasks complete

targos added a commit that referenced this pull request Jan 29, 2019

test: exit sequence sanity tests
Execute many module loads in worker in a loop
while exiting from the main thread at arbitrary
execution points, and make sure that the workers
quiesce without crashing.

`worker_threads` are not necessarily the subject of
testing, those are used for easy simulation of
multi-thread scenarios.

Refs: #25007
PR-URL: #25083
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment