Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: move process.binding('os') to internalBinding #25087

Closed
wants to merge 1 commit into from

Conversation

@briete
Copy link
Contributor

commented Dec 17, 2018

see: #22160
ref: #22292

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

@briete briete referenced this pull request Dec 17, 2018
2 of 2 tasks complete
@danbev

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

Landed in 937c769. 🎉

@danbev danbev closed this Dec 20, 2018

danbev added a commit that referenced this pull request Dec 20, 2018
os: move process.binding('os') to internalBinding
PR-URL: #25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request Dec 20, 2018
32 of 33 tasks complete

@briete briete deleted the briete:os-internal-binding branch Dec 25, 2018

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Dec 25, 2018

This does not land cleanly on v11.x, would someone be willing to backport?

@targos targos added this to Backport requested in v11.x Dec 28, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 9, 2019
os: move process.binding('os') to internalBinding
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 9, 2019
os: move process.binding('os') to internalBinding
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 9, 2019
4 of 4 tasks complete
BridgeAR added a commit that referenced this pull request Jan 10, 2019
os: move process.binding('os') to internalBinding
PR-URL: #25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR moved this from Backport requested to Backported in v11.x Jan 10, 2019

joyeecheung added a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
os: move process.binding('os') to internalBinding
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
os: move process.binding('os') to internalBinding
PR-URL: #25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #25446
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
os: move process.binding('os') to internalBinding
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
os: move process.binding('os') to internalBinding
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
os: move process.binding('os') to internalBinding
PR-URL: nodejs#25087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: nodejs#25446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
9 participants
You can’t perform that action at this time.