New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove obsolete eslint comments #25088

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
9 participants
@cjihrig
Copy link
Contributor

cjihrig commented Dec 17, 2018

The surrounding code was updated, making these eslint-disable comments obsolete.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@Trott

Trott approved these changes Dec 18, 2018

@targos

targos approved these changes Dec 18, 2018

@cjihrig cjihrig force-pushed the cjihrig:lint branch 2 times, most recently from feb4468 to 8df742d Dec 19, 2018

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Dec 19, 2018

test: remove obsolete eslint comments
The surrounding code was updated, making these eslint-disable
comments obsolete.

PR-URL: nodejs#25088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig

This comment has been minimized.

test: remove obsolete eslint comments
The surrounding code was updated, making these eslint-disable
comments obsolete.

PR-URL: #25088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:lint branch from 8df742d to 35a8906 Dec 19, 2018

@cjihrig cjihrig merged commit 35a8906 into nodejs:master Dec 19, 2018

@cjihrig cjihrig deleted the cjihrig:lint branch Dec 19, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

test: remove obsolete eslint comments
The surrounding code was updated, making these eslint-disable
comments obsolete.

PR-URL: #25088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

test: remove obsolete eslint comments
The surrounding code was updated, making these eslint-disable
comments obsolete.

PR-URL: nodejs#25088
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment