Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: improve inspectOptions validation #25090

Merged
merged 1 commit into from Dec 19, 2018

Conversation

@cjihrig
Copy link
Contributor

commented Dec 17, 2018

This commit adds stricter type checking to the inspectOptions option to the Console constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@targos
targos approved these changes Dec 17, 2018
@lpinca
lpinca approved these changes Dec 17, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

@Trott Trott added the author ready label Dec 18, 2018

console: improve inspectOptions validation
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:console branch from 575ef02 to bf36f07 Dec 19, 2018

@cjihrig cjihrig merged commit bf36f07 into nodejs:master Dec 19, 2018

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:console branch Dec 19, 2018

@MylesBorins MylesBorins added the v11.x label Dec 25, 2018

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Dec 25, 2018

This does not land cleanly on v11.x, would someone be willing to backport?

@targos targos added this to Backport requested in v11.x Dec 28, 2018

@targos

This comment has been minimized.

Copy link
Member

commented Jan 1, 2019

Depends on #24978

BridgeAR added a commit that referenced this pull request Jan 10, 2019
console: improve inspectOptions validation
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

Backported directly to the staging branch due to recent console backports.

@BridgeAR BridgeAR moved this from Backport requested to Backported in v11.x Jan 10, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019
console: improve inspectOptions validation
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
console: improve inspectOptions validation
This commit adds stricter type checking to the inspectOptions
option to the Console constructor.

PR-URL: nodejs#25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
10 participants
You can’t perform that action at this time.