New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing tmpdir.refresh() in recently-added test #25098

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@Trott
Copy link
Member

Trott commented Dec 17, 2018

Without tmpdir.refresh(), the test fails in some situations. This was
missed because using test.py will almost always result in a leftover
tmpdir lying around that makes the refresh() not needed.

Refs: #24913 (comment)

Collaborators, 馃憤 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: add missing tmpdir.refresh() in recently-added test
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: #24913 (comment)

@Trott Trott added the fast-track label Dec 17, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 17, 2018

@targos

targos approved these changes Dec 17, 2018

@targos

This comment has been minimized.

Copy link
Member

targos commented Dec 17, 2018

Thanks. This fixes my case, which was git clean -fdx && ./configure && make test -j8 V=

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 18, 2018

Landed in 3ccb900

@Trott Trott closed this Dec 18, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 18, 2018

test: add missing tmpdir.refresh() in recently-added test
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: nodejs#24913 (comment)

PR-URL: nodejs#25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

test: add missing tmpdir.refresh() in recently-added test
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: #24913 (comment)

PR-URL: #25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

@drewfish

This comment has been minimized.

Copy link
Contributor

drewfish commented Dec 27, 2018

Should the same changes also be made in test/parallel/test-child-process-spawnsync-args.js ?

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

test: add missing tmpdir.refresh() in recently-added test
Without `tmpdir.refresh()`, the test fails in some situations. This was
missed because using `test.py` will almost always result in a leftover
tmpdir lying around that makes the `refresh()` not needed.

Refs: nodejs#24913 (comment)

PR-URL: nodejs#25098
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment