New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: correct fi indentation in Makefile #25107

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@danbev
Copy link
Member

danbev commented Dec 18, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Dec 18, 2018

@danbev

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 21, 2018

Re-run of failing node-test-commit-linux ✔️

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 21, 2018

Landed in 4ac1702.

@danbev danbev closed this Dec 21, 2018

@danbev danbev deleted the danbev:makefile-if-indentation branch Dec 21, 2018

danbev added a commit that referenced this pull request Dec 21, 2018

build: correct fi indentation in Makefile
PR-URL: #25107
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

build: correct fi indentation in Makefile
PR-URL: #25107
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

build: correct fi indentation in Makefile
PR-URL: #25107
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

build: correct fi indentation in Makefile
PR-URL: nodejs#25107
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment