New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: use uv_os_gethostname() in hostname() #25111

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
7 participants
@cjihrig
Copy link
Contributor

cjihrig commented Dec 18, 2018

This commit changes the C++ implementation of os.hostname() to use uv_os_gethostname().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Fishrock123

This comment has been minimized.

Copy link
Member

Fishrock123 commented Dec 19, 2018

What is the expected impact of this?

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 19, 2018

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Dec 19, 2018

What is the expected impact of this?

Just code cleanup.

os: use uv_os_gethostname() in hostname()
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:hostname branch from 57c7549 to 3438f4b Dec 20, 2018

@cjihrig cjihrig merged commit 3438f4b into nodejs:master Dec 20, 2018

@cjihrig cjihrig deleted the cjihrig:hostname branch Dec 20, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

os: use uv_os_gethostname() in hostname()
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

os: use uv_os_gethostname() in hostname()
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: #25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

os: use uv_os_gethostname() in hostname()
This commit changes the C++ implementation of os.hostname()
to use uv_os_gethostname().

PR-URL: nodejs#25111
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment