New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] test: fix expectation in test-bootstrap-modules #25112

Closed
wants to merge 2 commits into
base: v10.x-staging
from

Conversation

Projects
None yet
4 participants
@ofrobots
Copy link
Contributor

ofrobots commented Dec 18, 2018

@ofrobots ofrobots changed the title test: fix expectation in test-bootstrap-modules [10.x] test: fix expectation in test-bootstrap-modules Dec 18, 2018

@ofrobots ofrobots referenced this pull request Dec 18, 2018

Closed

[10.x] deps: V8: cherry-pick 52a9e67 #25027

2 of 2 tasks complete
@MylesBorins
Copy link
Member

MylesBorins left a comment

LGTM

This test seems kinda fragile though if the environment can make it pass / fail

@ofrobots

This comment has been minimized.

Copy link
Contributor

ofrobots commented Dec 20, 2018

@nodejs/backporters this is ready to land.

codebytere added a commit that referenced this pull request Dec 21, 2018

test: fix expectation in test-bootstrap-modules
PR-URL: #25112
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Dec 21, 2018

landed in 13fead6

@codebytere codebytere closed this Dec 21, 2018

MylesBorins added a commit that referenced this pull request Dec 21, 2018

test: fix expectation in test-bootstrap-modules
PR-URL: #25112
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 21, 2018

Merged

v10.15.0 proposal #25176

MylesBorins added a commit that referenced this pull request Dec 22, 2018

test: fix expectation in test-bootstrap-modules
PR-URL: #25112
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 22, 2018

test: fix expectation in test-bootstrap-modules
PR-URL: #25112
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

test: fix expectation in test-bootstrap-modules
PR-URL: #25112
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment