Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for http request set timeout #25121

Conversation

@jbunton-atlassian
Copy link
Contributor

commented Dec 19, 2018

When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)

Also see #25123 for an update to the v8.x docs.

Thanks :)

Checklist
@mscdex

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2018

I'm confused. This PR currently contains more than a documentation change.

@jbunton-atlassian jbunton-atlassian force-pushed the jbunton-atlassian:update_docs_for_http_request_setTimeout branch from ed4ac0d to 84cd47b Dec 19, 2018

@jbunton-atlassian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2018

@mscdex, sorry again! I created these doc commits from a branch where I'm trying to track down another problem.

I've rebased to exclude the non-doc change.

doc/api/http.md Outdated Show resolved Hide resolved

@lpinca lpinca added http doc and removed child_process labels Dec 19, 2018

@jbunton-atlassian jbunton-atlassian force-pushed the jbunton-atlassian:update_docs_for_http_request_setTimeout branch from 84cd47b to 2b4d26a Dec 19, 2018

@lpinca
lpinca approved these changes Dec 19, 2018
@jbunton-atlassian

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2018

Thanks @lpinca :)

@jbunton-atlassian jbunton-atlassian force-pushed the jbunton-atlassian:update_docs_for_http_request_setTimeout branch 2 times, most recently from 84cd47b to 2b4d26a Dec 19, 2018

doc/api/http.md Outdated Show resolved Hide resolved

@jbunton-atlassian jbunton-atlassian force-pushed the jbunton-atlassian:update_docs_for_http_request_setTimeout branch from 2b4d26a to 5708c6a Dec 19, 2018

@vsemozhetbyt

This comment has been minimized.

@jbunton-atlassian

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

Hi there, could somebody please merge this for me? Thanks!

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Landed in b83088b
Thank you!

vsemozhetbyt added a commit that referenced this pull request Jan 9, 2019
doc: add history to http.request.setTimeout()
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
doc: add history to http.request.setTimeout()
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
doc: add history to http.request.setTimeout()
PR-URL: nodejs#25121
Refs: nodejs#8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
doc: add history to http.request.setTimeout()
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: add history to http.request.setTimeout()
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: add history to http.request.setTimeout()
PR-URL: #25121
Refs: #8895
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.