Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark sequential/test-inspector-debug-end and parallel/test-child-process-execfile as flaky #25126

Closed
wants to merge 1 commit into from

Conversation

@gireeshpunathil
Copy link
Member

commented Dec 19, 2018

Off late this has been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart it as flaky in AIX until that is resolved.

Refs: #25047

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@gireeshpunathil gireeshpunathil requested a review from Trott Dec 19, 2018

@gireeshpunathil gireeshpunathil added the aix label Dec 19, 2018

test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

@gireeshpunathil gireeshpunathil force-pushed the gireeshpunathil:aix_flake branch from 364e919 to c1ca1f4 Dec 19, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2018

added an entry for the issue pertinent to #25029 as well, in this.

@gireeshpunathil gireeshpunathil changed the title test: mark sequential/test-inspector-debug-end as flaky test: mark sequential/test-inspector-debug-end and parallel/test-child-process-execfile as flaky Dec 19, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

commented Dec 27, 2018

One week with a single approval, contemplating to land.

CI: https://ci.nodejs.org/job/node-test-pull-request/19829/

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2018

landed as 7a867b8

gireeshpunathil added a commit that referenced this pull request Dec 28, 2018
test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this pull request Jan 1, 2019
test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in nodejs#25007
Mart these  as flaky in AIX until that is resolved.

Refs: nodejs#25047
Refs: nodejs#25029

PR-URL: nodejs#25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 17, 2019
test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 28, 2019
test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins added a commit that referenced this pull request May 16, 2019
test: mark two tests as flaky in AIX
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.