Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_events: move SetupTraceCategoryState into node_trace_events.cc #25128

Closed
wants to merge 2 commits into from

Conversation

@joyeecheung
Copy link
Member

commented Dec 19, 2018

It makes more sense to put it in internalBinding('trace_events')
instead of in the bootstrapper object.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
trace_events: move SetupTraceCategoryState into node_trace_events.cc
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2018

const { traceCategoryState } = internalBinding('trace_events');
const {
traceCategoryState,
setupTraceCategoryState

This comment has been minimized.

Copy link
@targos

targos Dec 19, 2018

Member

Could you use another name (avoid that of the current executing function)?

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Dec 19, 2018

@targos Thanks for catching that, I updated the internal function name to setTraceCategoryStateUpdateHandler since that's what it actually does. PTAL.

@targos
targos approved these changes Dec 19, 2018
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2018

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

joyeecheung added a commit that referenced this pull request Dec 21, 2018
trace_events: move SetupTraceCategoryState into node_trace_events.cc
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.

PR-URL: #25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2018

Landed in 70f2328, thanks!

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Dec 25, 2018

This doesn't land cleanly on v11.x, should it be backported?

@targos targos added this to Backport requested in v11.x Dec 28, 2018

refack added a commit to refack/node that referenced this pull request Jan 14, 2019
trace_events: move SetupTraceCategoryState into node_trace_events.cc
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.

PR-URL: nodejs#25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 14, 2019

This applies cleanly now.

addaleax added a commit that referenced this pull request Jan 14, 2019
trace_events: move SetupTraceCategoryState into node_trace_events.cc
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.

PR-URL: #25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR moved this from Backport requested to Backported in v11.x Jan 14, 2019

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
trace_events: move SetupTraceCategoryState into node_trace_events.cc
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.

PR-URL: nodejs#25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
8 participants
You can’t perform that action at this time.