Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: remove use less internalFS #25161

Closed

Conversation

Projects
None yet
7 participants
@ZYSzys
Copy link
Member

commented Dec 21, 2018

internalFS is just used once in the whole fs.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@targos

targos approved these changes Dec 21, 2018

@lpinca

lpinca approved these changes Dec 21, 2018

@lpinca

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

@lpinca

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

Landed in 3681ddd.

@lpinca lpinca closed this Feb 9, 2019

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Feb 9, 2019

fs: remove useless internalFS
PR-URL: nodejs#25161
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@ZYSzys ZYSzys deleted the zys-contribs:fs-remove-use-less-internal-fs branch Feb 10, 2019

targos added a commit that referenced this pull request Feb 10, 2019

fs: remove useless internalFS
PR-URL: #25161
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Feb 14, 2019

Merged

v11.10.0 proposal #26098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.