New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove Files: comment processing from Python test runner #25183

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@Trott
Copy link
Member

Trott commented Dec 22, 2018

We don't use any Files: comments in our tests so remove the Python code
for it from test/testpy/init.py.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: remove Files: comment processing from Python test runner
We don't use any Files: comments in our tests so remove the Python code
for it from test/testpy/__init__.py.
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 22, 2018

@targos

targos approved these changes Dec 22, 2018

@Trott Trott added the author ready label Dec 22, 2018

@lpinca

lpinca approved these changes Dec 22, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 23, 2018

Landed in bcea74f

@Trott Trott closed this Dec 23, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 23, 2018

test: remove Files: comment processing from Python test runner
We don't use any Files: comments in our tests so remove the Python code
for it from test/testpy/__init__.py.

PR-URL: nodejs#25183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 23, 2018

Argh, I misread "PM" for "AM" and landed this 12 hours early. Sorry. Since there aren't a lot of commits landing right around now, reverting this shouldn't be a big deal if anyone has issues with it. It's a small and easy-to-reverse change. Sorry about the error. (I also mis-read 9:54 as 9:45 but that's a smaller problem.)

MylesBorins added a commit that referenced this pull request Dec 25, 2018

test: remove Files: comment processing from Python test runner
We don't use any Files: comments in our tests so remove the Python code
for it from test/testpy/__init__.py.

PR-URL: #25183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

test: remove Files: comment processing from Python test runner
We don't use any Files: comments in our tests so remove the Python code
for it from test/testpy/__init__.py.

PR-URL: #25183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

test: remove Files: comment processing from Python test runner
We don't use any Files: comments in our tests so remove the Python code
for it from test/testpy/__init__.py.

PR-URL: nodejs#25183
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment