New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-tls-session-timeout #25188

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Trott
Copy link
Member

Trott commented Dec 23, 2018

Tests in pummel seem to break often and stay broken because they don't
get run in CI. In preparation for running pummel tests in CI once a day,
this fixes test-tls-session-timeout. key and cert are now the
contents of the relevant files and not the paths.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: fix test-tls-session-timeout
Tests in pummel seem to break often and stay broken because they don't
get run in CI. In preparation for running pummel tests in CI once a day,
this fixes test-tls-session-timeout. `key` and `cert` are now the
contents of the relevant files and not the paths.
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 23, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 23, 2018

Because pummel tests are not yet run in CI at all, lite CI should be sufficient here.

Show resolved Hide resolved test/pummel/test-tls-session-timeout.js Outdated
@lpinca

lpinca approved these changes Dec 23, 2018

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 25, 2018

Landed in 9391638

@Trott Trott closed this Dec 25, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 25, 2018

test: fix test-tls-session-timeout
Tests in pummel seem to break often and stay broken because they don't
get run in CI. In preparation for running pummel tests in CI once a day,
this fixes test-tls-session-timeout. `key` and `cert` are now the
contents of the relevant files and not the paths.

PR-URL: nodejs#25188
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

test: fix test-tls-session-timeout
Tests in pummel seem to break often and stay broken because they don't
get run in CI. In preparation for running pummel tests in CI once a day,
this fixes test-tls-session-timeout. `key` and `cert` are now the
contents of the relevant files and not the paths.

PR-URL: #25188
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

test: fix test-tls-session-timeout
Tests in pummel seem to break often and stay broken because they don't
get run in CI. In preparation for running pummel tests in CI once a day,
this fixes test-tls-session-timeout. `key` and `cert` are now the
contents of the relevant files and not the paths.

PR-URL: #25188
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

test: fix test-tls-session-timeout
Tests in pummel seem to break often and stay broken because they don't
get run in CI. In preparation for running pummel tests in CI once a day,
this fixes test-tls-session-timeout. `key` and `cert` are now the
contents of the relevant files and not the paths.

PR-URL: nodejs#25188
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment