New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 5.11.0 #25191

Merged
merged 1 commit into from Dec 25, 2018

Conversation

Projects
None yet
5 participants
@cjihrig
Copy link
Contributor

cjihrig commented Dec 23, 2018

Update ESLint to 5.11.0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@Trott

Trott approved these changes Dec 23, 2018

Copy link
Member

Trott left a comment

Nice tiny change set for an ESLint upgrade.

@Trott Trott added the author ready label Dec 23, 2018

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 23, 2018

(Lint job is run in lite CI and there is no additional linting in the full CI, so this is author ready.)

@trivikr
Copy link
Contributor

trivikr left a comment

RSLGTM

@BridgeAR
Copy link
Member

BridgeAR left a comment

RSLGTM

tools: update ESLint to 5.11.0
Update ESLint to 5.11.0.

PR-URL: #25191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@cjihrig cjihrig force-pushed the cjihrig:eslint branch from 37531e5 to db2b612 Dec 25, 2018

@cjihrig cjihrig merged commit db2b612 into nodejs:master Dec 25, 2018

@cjihrig cjihrig deleted the cjihrig:eslint branch Dec 25, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

tools: update ESLint to 5.11.0
Update ESLint to 5.11.0.

PR-URL: #25191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

tools: update ESLint to 5.11.0
Update ESLint to 5.11.0.

PR-URL: #25191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

tools: update ESLint to 5.11.0
Update ESLint to 5.11.0.

PR-URL: nodejs#25191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment