Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix compiler warnings in node_crypto.cc #25205

Merged
merged 1 commit into from Dec 26, 2018

Conversation

@cjihrig
Copy link
Contributor

commented Dec 24, 2018

During the time between #24234 being opened and it landing, a V8 update occurred that deprecated several APIs. This commit fixes the following compiler warnings:

../src/node_crypto.cc:3342:11: warning: 'Set' is deprecated: Use maybe version

../src/node_crypto.cc:3345:13: warning: 'GetFunction' is deprecated: Use maybe version
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@tniessen

This comment has been minimized.

Copy link
Member

commented Dec 24, 2018

Thanks Colin!

@danbev
danbev approved these changes Dec 25, 2018
@danbev

This comment has been minimized.

Copy link
Member

commented Dec 25, 2018

@Trott Trott added the author ready label Dec 25, 2018

src: fix compiler warnings in node_crypto.cc
During the time between #24234
being opened and it landing, a V8 update occurred that deprecated
several APIs. This commit fixes the following compiler warnings:

../src/node_crypto.cc:3342:11:
  warning: 'Set' is deprecated: Use maybe version

../src/node_crypto.cc:3345:13:
  warning: 'GetFunction' is deprecated: Use maybe version

PR-URL: #25205
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:warning branch from c5655df to 0951995 Dec 26, 2018

@cjihrig cjihrig merged commit 0951995 into nodejs:master Dec 26, 2018

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:warning branch Dec 26, 2018

targos added a commit that referenced this pull request Jan 1, 2019
src: fix compiler warnings in node_crypto.cc
During the time between #24234
being opened and it landing, a V8 update occurred that deprecated
several APIs. This commit fixes the following compiler warnings:

../src/node_crypto.cc:3342:11:
  warning: 'Set' is deprecated: Use maybe version

../src/node_crypto.cc:3345:13:
  warning: 'GetFunction' is deprecated: Use maybe version

PR-URL: #25205
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: fix compiler warnings in node_crypto.cc
During the time between nodejs#24234
being opened and it landing, a V8 update occurred that deprecated
several APIs. This commit fixes the following compiler warnings:

../src/node_crypto.cc:3342:11:
  warning: 'Set' is deprecated: Use maybe version

../src/node_crypto.cc:3345:13:
  warning: 'GetFunction' is deprecated: Use maybe version

PR-URL: nodejs#25205
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.