Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: move process.features initialization into node.js #25239

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Dec 27, 2018

Use internalBinding('config') to shim the legacy
process.features.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@joyeecheung joyeecheung force-pushed the joyeecheung:port-features branch from 277a2ea to a7f3f89 Dec 27, 2018

process: move process.features initialization into node.js
Use `internalBinding('config')` to shim the legacy
`process.features`.

@joyeecheung joyeecheung force-pushed the joyeecheung:port-features branch from a7f3f89 to bc1ceb8 Dec 27, 2018

debug: isDebugBuild,
uv: true,
ipv6: true, // TODO(bnoordhuis) ping libuv
tls_alpn: hasOpenSSL,

This comment has been minimized.

Copy link
@joyeecheung

joyeecheung Dec 27, 2018

Author Member

This should also be available as process.versions.openssl even though that's not the purpose of that property - I wonder if we should just use that instead?

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Dec 27, 2018

@addaleax

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

@addaleax

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

Landed in 39a2ac4

@addaleax addaleax closed this Dec 31, 2018

addaleax added a commit that referenced this pull request Dec 31, 2018
process: move process.features initialization into node.js
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: #25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@BridgeAR BridgeAR added this to Backport requested in v11.x Jan 10, 2019

refack added a commit to refack/node that referenced this pull request Jan 14, 2019
process: move process.features initialization into node.js
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

This applies cleanly now :)

addaleax added a commit that referenced this pull request Jan 15, 2019
process: move process.features initialization into node.js
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: #25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
process: move process.features initialization into node.js
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
process: move process.features initialization into node.js
Use `internalBinding('config')` to shim the legacy
`process.features`.

PR-URL: nodejs#25239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019

@targos targos removed this from Backport requested in v11.x Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.