Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: include license for src/large_pages in LICENSE #25246

Closed
wants to merge 1 commit into from

Conversation

@ryzokuken
Copy link
Member

commented Dec 28, 2018

Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @Trott @kapouer

doc: include license for src/large_pages in LICENSE
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238
@ryzokuken

This comment has been minimized.

@Trott
Trott approved these changes Dec 28, 2018
@ryzokuken

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2018

Since the weekend is kicking around and this change is almost purely cosmetic, please respond with 👍 to suggest fast-tracking this.

@lpinca
lpinca approved these changes Dec 28, 2018
@kapouer

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2018

LGTM.

@addaleax

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 31, 2018

Landed in 48a88c8

@Trott Trott closed this Dec 31, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 31, 2018
doc: include license for src/large_pages in LICENSE
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: nodejs#25238

PR-URL: nodejs#25246
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Jan 1, 2019
doc: include license for src/large_pages in LICENSE
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: include license for src/large_pages in LICENSE
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: nodejs#25238

PR-URL: nodejs#25246
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
doc: include license for src/large_pages in LICENSE
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
doc: include license for src/large_pages in LICENSE
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins added a commit that referenced this pull request May 16, 2019
doc: include license for src/large_pages in LICENSE
Include License for src/large_pages (MIT licensed by Intel), to the main
LICENSE file and make required changes to the tools/license-builder.sh
script.

Fixes: #25238

PR-URL: #25246
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.