Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: cleanup util #25255

Closed
wants to merge 5 commits into from

Conversation

@BridgeAR
Copy link
Member

commented Dec 28, 2018

Just some cleanup while trying to figure out some other things.

Please have a look at the commit messages for details.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
BridgeAR added 5 commits Dec 28, 2018
util: switch recurseTimes counter
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.
util: code cleanup
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.
util: simpler module namespace code
This removes a special casing for this data type in the main function.
util: remove outdated comment
This comment is not correct anymore.
util: remove eslint comments and rename variables
This should improve the readability of the code.
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@nodejs/util PTAL

This is open for quite some while without getting any reviews.

@jasnell
jasnell approved these changes Jan 9, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@danbev danbev closed this Jan 11, 2019

danbev added a commit that referenced this pull request Jan 11, 2019
util: switch recurseTimes counter
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev added a commit that referenced this pull request Jan 11, 2019
util: code cleanup
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev added a commit that referenced this pull request Jan 11, 2019
util: simpler module namespace code
This removes a special casing for this data type in the main function.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev added a commit that referenced this pull request Jan 11, 2019
util: remove outdated comment
This comment is not correct anymore.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev added a commit that referenced this pull request Jan 11, 2019
util: remove eslint comments and rename variables
This should improve the readability of the code.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
util: switch recurseTimes counter
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
util: code cleanup
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
util: simpler module namespace code
This removes a special casing for this data type in the main function.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
util: remove outdated comment
This comment is not correct anymore.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Jan 14, 2019
util: remove eslint comments and rename variables
This should improve the readability of the code.

PR-URL: #25255
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
util: switch recurseTimes counter
This makes sure the counter goes up instead of going down. This allows
to properly track the current inspection depth no matter what the
`depth` option was set to.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
util: code cleanup
Remove some dead code plus some minor refactoring for readability.
The constructor can not be an empty string anymore, so just remove
that check.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
util: simpler module namespace code
This removes a special casing for this data type in the main function.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
util: remove outdated comment
This comment is not correct anymore.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
util: remove eslint comments and rename variables
This should improve the readability of the code.

PR-URL: nodejs#25255
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.