Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: extract start and end check into checkPosition #25264

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Dec 29, 2018

this.start and this.end in ReadStream meet the same conditions, extract their check into checkPosition function.

Maybe we can use it to check this.start in WriteStream too(but may need to do other works).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Dec 29, 2018
@addaleax

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Landed in 98ed23c

@addaleax addaleax closed this Jan 9, 2019

addaleax added a commit that referenced this pull request Jan 9, 2019
fs: extract start and end check into checkPosition
PR-URL: #25264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit that referenced this pull request Jan 9, 2019
fs: extract start and end check into checkPosition
PR-URL: #25264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
fs: extract start and end check into checkPosition
PR-URL: nodejs#25264
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@ZYSzys ZYSzys deleted the zys-contribs:fs-internal-streams branch Jan 18, 2019

@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.